Re-Identification Model #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earning (loss). Added custom reID/embedding metrics. Implemented a test to verify trainability, exportability and inference. Removed GhostFaceNetsV2 from the backbone tests as it only generates embeddings instead of the usual features.
CaptainTrojan
requested review from
kozlov721,
klemen1999,
tersekmatija and
conorsim
and removed request for
a team
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
- Coverage 96.31% 95.31% -1.01%
==========================================
Files 147 178 +31
Lines 6304 7956 +1652
==========================================
+ Hits 6072 7583 +1511
- Misses 232 373 +141 ☔ View full report in Codecov by Sentry. |
kozlov721
reviewed
Dec 9, 2024
tersekmatija
reviewed
Dec 9, 2024
…locks and variants. Added tests for all supported pytorch metric learning losses.
|
Thanks very much everyone for the review and suggestions. Incorporated everything in, except for the new luxonis-ml nested label changes, as that should probably be done in a different PR. Thoughts? |
|
Locally, I'm getting Could it be that I have a wrong version of mdformat? |
…s-train into feat/reid-support
…s-train into feat/reid-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original CU Task
Added the GFNv2 backbone for use in re-ID tasks. Added integration with pytorch-metric-learning for ~30 loss functions (customizable) and two custom reID/embedding metrics. Implemented a test to verify trainability, exportability and inference.